Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update transaction construction examples for latest changes #33

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

kokahunter
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Apr 10, 2022

Deploy Preview for clever-mclean-ad3de1 ready!

Name Link
🔨 Latest commit 2728b79
🔍 Latest deploy log https://app.netlify.com/sites/clever-mclean-ad3de1/deploys/6252ef38b7c7760009364c17
😎 Deploy Preview https://deploy-preview-33--clever-mclean-ad3de1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@apisit
Copy link
Collaborator

apisit commented Apr 12, 2022

Is this update from the latest version of the SDK? If so, Can you provide more info?

@kokahunter
Copy link
Contributor Author

Yes, I've used Neo.Network.RPC.RpcClient 3.1.0 and .net6.0

Basically i tried out the code snippets but they would not work without following changes:

  • Utility is an ambiguous referecen between Neo.Utlity and Neo.Network.RPC.Utility, so need to add using Utility = Neo.Network.RPC.Utility;
  • RpcClient needs to be initialized at least with new URI(...)
  • Utility.GetScriptHash needs ProtocolSettings as second parameter.
    • So either using ProtocolSettings.Default (that is MainNet)
    • Or creating own ProtocolSettings with config file
  • scriptHash.MakeScript("transfer", sender, receiver, 1024, null); was failing in final TX if 4th parameter was not added explicitly
  • TransactionManagerFactory does only take 1 paramter RpcClient
  • Contract.CreateMultiSigContract takes a IReadOnlyCollection as input parameter
    • Here im not 100% sure how to handle it the best way

Since 3.2.0 is on the way maybe better wait and evaluate again?

@kokahunter
Copy link
Contributor Author

@dotnet-policy-service agree

@Celia18305 Celia18305 merged commit c5a391c into neo-project:dev Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants